On the backports-v1.8 branch, run CI on v1.8 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we open a PR to merge backports-release-1.8 => release-1.8 with this in it? That should trigger CI right? |
Yes. We could do that right away, or include the vcat fix before that. But I guess the order doesn't matter much as long as we don't change the commit SHA in Julia |
|
I'm merging this. It can't be wrong to do that IIUC. |
Yeah I say we merge into backports and just open a PR for CI purposes. Once we've done that and it passes we can follow up with Kristoffer or Dilum to be absolutely sure we've got it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe replaces #255?