Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let length(::SparseVector{Tv,Ti}) return Ti #176

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Conversation

dkarrasch
Copy link
Member

Fixes JuliaLang/julia#45937.

Should be backported to v1.8.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #176 (4fa7ea5) into main (e081db6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   91.66%   91.67%   +0.01%     
==========================================
  Files          11       11              
  Lines        7102     7103       +1     
==========================================
+ Hits         6510     6512       +2     
+ Misses        592      591       -1     
Impacted Files Coverage Δ
src/sparsevector.jl 94.17% <100.00%> (+<0.01%) ⬆️
src/linalg.jl 84.50% <0.00%> (+0.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fredrikekre fredrikekre merged commit c5ddb5b into main Jul 9, 2022
@fredrikekre fredrikekre deleted the dk/veclength branch July 9, 2022 11:17
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-176-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c5ddb5b397642dd4624224e4a12553272882a33f
# Push it to GitHub
git push --set-upstream origin backport-176-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-176-to-1.8.

@dkarrasch dkarrasch mentioned this pull request Sep 16, 2022
4 tasks
dkarrasch added a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make (again) length type match index type in sparse vectors
3 participants