decrement should always return a vector (#241)

* decremenet should always return a vector * fix performance * fix performance issue
JuliaSparse · Sep 6, 2022 · d88be9f · d88be9f
1 parent dfcc48a
commit d88be9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/SparseArrays.jl b/src/SparseArrays.jl
@@ -49,8 +49,9 @@ function decrement!(A::AbstractArray{T}) where T<:Integer
     for i in eachindex(A); A[i] -= oneunit(T) end
     A
 end
-decrement(A::AbstractArray{<:Integer}) = decrement!(copy(A))
-
+decrement(A::AbstractArray) = let y = Array(A)
+    y .= y .- oneunit(eltype(A))
+end
 
 include("readonly.jl")
 include("abstractsparse.jl")

diff --git a/src/readonly.jl b/src/readonly.jl
@@ -37,5 +37,3 @@ Base.copy(x::ReadOnly) = ReadOnly(copy(parent(x)))
 (==)(x::ReadOnly, y::ReadOnly) = parent(x) == parent(y)
 
 Base.dataids(::ReadOnly) = tuple()
-# Convert from 1-based to 0-based indices
-decrement(A::ReadOnly) = decrement!(copy(parent(A)))