Reduce julia inference time for ExceptionUnwrapping.jl #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nospecialize
to prevent julia from codegen'ing specializationsfor every possible combination of wrapped exception types, since the
resultant code will be essentially the same, and we don't mind
paying the runtime cost for the (rare!) exception handling
codepaths.
these functions until they're actually called (at the price of one
extra dispatch during exception handling).
julia would have attempted to statically resolve the recursion, and
we saw it hit a stack overflow during inference in production.