use @defVariable for RoME Variable Types #328
Conversation
|
towards #244 |
bump DFG compat to v0.10.2
|
shall we target a minor release on RoME then, v0.10.0 is next. This is really great! Thanks for doing! |
|
|
||
| #uses DFG v0.10.2 @defVariable for above | ||
| include("variables/VariableTypes.jl") |
There was a problem hiding this comment.
@dehann is it ok to have all variable definitions in one file like this?
There was a problem hiding this comment.
yeah, saw you did that -- think that will work well thanks otherwise they are all over the place -- good call!
|
Still to do is to update all the test that uses the old softtype |
|
Maybe convert on nstime from second, millisecond, float, etc. |
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 15.19% 16.68% +1.48%
==========================================
Files 43 43
Lines 2145 2200 +55
==========================================
+ Hits 326 367 +41
- Misses 1819 1833 +14
Continue to review full report at Codecov.
|
|
this will cross paths with #341 sooner or later. |
replace #304
|
Awesome, thanks! |
Just testing it for now. Needs DFG v0.10.2