Add CatVector #577
Open
Add CatVector #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoolen
commented
Dec 31, 2019
src/custom_collections/CatVector.jl
Outdated
| i += 1 | ||
| end | ||
| end | ||
| error() |
src/custom_collections/CatVector.jl
Outdated
| i += 1 | ||
| end | ||
| end | ||
| error() |
src/custom_collections/CatVector.jl
Outdated
| end | ||
|
|
||
| @inline Base.size(vec::CatVector) = (mapreduce(length, +, vec.vecs; init=0),) | ||
| Base.eltype(vec::CatVector) = eltype(eltype(vec.vecs)) |
src/custom_collections/CatVector.jl
Outdated
| Base.similar(vec::CatVector, ::Type{T}) where {T} = CatVector(map(x -> similar(x, T), vec.vecs)) | ||
|
|
||
| @inline function check_cat_vectors_line_up(x::CatVector, y::CatVector) | ||
| length(x.vecs) == length(y.vecs) || throw(ArgumentError("Subvectors must line up")) |
src/custom_collections/CatVector.jl
Outdated
| @inline function check_cat_vectors_line_up(x::CatVector, y::CatVector) | ||
| length(x.vecs) == length(y.vecs) || throw(ArgumentError("Subvectors must line up")) | ||
| for i in eachindex(x.vecs) | ||
| length(x.vecs[i]) == length(y.vecs[i]) || throw(ArgumentError("Subvectors must line up")) |
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
========================================
- Coverage 89.19% 89% -0.19%
========================================
Files 51 52 +1
Lines 3148 3212 +64
========================================
+ Hits 2808 2859 +51
- Misses 340 353 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be needed for upcoming changes related to simultaneous simulation of multiple mechanisms (#572, which might still take a while).
TODO: