Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 0.7 #451

Merged
merged 30 commits into from
Jul 9, 2018
Merged

Fixes for 0.7 #451

merged 30 commits into from
Jul 9, 2018

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Jul 3, 2018

Skip IntervalArithmetic and SymPy notebooks for now.

Had to temporarily disable test case involving Hessian of kinetic energy due to excessive compilation time.

Currently some allocations that I still need to debug, but overall benchmarks have improved signficantly.

@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #451 into master will increase coverage by 2.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #451     +/-   ##
=========================================
+ Coverage   96.88%   99.18%   +2.3%     
=========================================
  Files          29       28      -1     
  Lines        2695     1601   -1094     
=========================================
- Hits         2611     1588   -1023     
+ Misses         84       13     -71
Impacted Files Coverage Δ
src/custom_collections.jl 100% <ø> (+4.65%) ⬆️
src/contact.jl 100% <ø> (+5.26%) ⬆️
src/pdcontrol.jl 100% <ø> (ø) ⬆️
src/joint.jl 100% <ø> (+3.36%) ⬆️
src/dynamics_result.jl 100% <ø> (+10.2%) ⬆️
src/parse_urdf.jl 95.6% <ø> (-0.44%) ⬇️
src/ode_integrators.jl 100% <ø> (+2.65%) ⬆️
src/spatial/spatialmotion.jl 100% <100%> (+1.69%) ⬆️
src/rigid_body.jl 94.59% <100%> (+3.1%) ⬆️
src/joint_types.jl 100% <100%> (+3.35%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611aaf0...ea6c2aa. Read the comment docs.

@tkoolen
Copy link
Collaborator Author

tkoolen commented Jul 4, 2018

Allocations (except in constraint_jacobian!) are fixed by JuliaArrays/StaticArrays.jl#461. I'll at least wait for StaticArrays 0.8.1 to be tagged before merging this.

tkoolen added 3 commits July 9, 2018 08:27
eye -> one for SMatrix.

eye -> one for Rotations.RotMatrix.

zeros -> zero for StaticArrays types.
@tkoolen
Copy link
Collaborator Author

tkoolen commented Jul 9, 2018

Allocation fixes for constraint_jacobian! and constraint_bias! will come in a separate PR.

@tkoolen tkoolen merged commit fb97f95 into master Jul 9, 2018
@tkoolen tkoolen deleted the tk/julia-0.7 branch July 9, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants