Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP CSM cycle problem, #754 #936

Merged
merged 6 commits into from
Oct 1, 2020
Merged

WIP CSM cycle problem, #754 #936

merged 6 commits into from
Oct 1, 2020

Conversation

dehann
Copy link
Member

@dehann dehann commented Oct 1, 2020

related to but does not yet fix #754

@dehann dehann added this to the v0.16.0 milestone Oct 1, 2020
@dehann dehann marked this pull request as ready for review October 1, 2020 14:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #936 into master will decrease coverage by 0.06%.
The diff coverage is 87.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   61.53%   61.47%   -0.07%     
==========================================
  Files          52       52              
  Lines        4971     4978       +7     
==========================================
+ Hits         3059     3060       +1     
- Misses       1912     1918       +6     
Impacted Files Coverage Δ
src/TreeBasedInitialization.jl 68.93% <68.57%> (-4.84%) ⬇️
src/CliqStateMachine.jl 83.28% <97.50%> (+0.74%) ⬆️
src/SolveTree.jl 66.37% <100.00%> (+6.79%) ⬆️
src/BeliefTypes.jl 17.94% <0.00%> (-4.64%) ⬇️
src/GraphProductOperations.jl 94.62% <0.00%> (-2.19%) ⬇️
src/SolveTree_Parametric.jl 92.15% <0.00%> (-2.17%) ⬇️
src/CliqStateMachine_Parametric.jl 80.33% <0.00%> (-1.64%) ⬇️
src/JunctionTree.jl 73.04% <0.00%> (+0.12%) ⬆️
src/SolverAPI.jl 70.68% <0.00%> (+1.17%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a0d17...7bde940. Read the comment docs.

@dehann dehann merged commit d410dcc into master Oct 1, 2020
@dehann dehann changed the title resolve CSM cycle problem, #754 WIP CSM cycle problem, #754 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSM init endless cycle MWE fail case
2 participants