Refactor Parametric solve for better performance and better use of Manopt.jl #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new does not support conditional * old renamed to solveRLM_conditional (used in init) * old only supports one point type * solveRLM_sparse can be deleted, new performs better * 0.875540 seconds (5.11 M allocations: 543.265 MiB, 9.95% gc time)
Affie
force-pushed
the
23Q3/dev/parametric
branch
from
8e0dd93 to
b586be3
Compare
dehann
reviewed
Oct 9, 2023
dehann
reviewed
Oct 9, 2023
Co-authored-by: Dehann Fourie <[email protected]>
Fix mixture sampling and deconv for static arrays
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
+ Coverage 50.30% 51.82% +1.51%
==========================================
Files 80 80
Lines 5848 5961 +113
==========================================
+ Hits 2942 3089 +147
+ Misses 2906 2872 -34
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress tracked in #1546
Needs: #1776