Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes, debugging, wip on DERelative tests #1774

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Sep 15, 2023

One issue remains with solveTree breaking the result. See broken_tests in this PR. The issue is that although initAll! does good job, the follow-on solve tree with .useMsgLikelihoods=false (over 4 cliques) resets some of the variables to values [0,0], and so:

  • This problem might not be specific to DERelative, and will resolve in a next PR.
  • Also going to use a separate PR to move sampling code from sampleFactor to getSample instead (finally able with new CalcFactor design).

some improvements relating to:

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1774 (60ad0a2) into master (bb689ff) will decrease coverage by 24.01%.
The diff coverage is 70.00%.

@@             Coverage Diff             @@
##           master    #1774       +/-   ##
===========================================
- Coverage   74.32%   50.32%   -24.01%     
===========================================
  Files          81       80        -1     
  Lines        5866     5846       -20     
===========================================
- Hits         4360     2942     -1418     
- Misses       1506     2904     +1398     
Files Changed Coverage Δ
ext/IncrInfrDiffEqFactorExt.jl 0.00% <0.00%> (ø)
src/services/CalcFactor.jl 54.77% <ø> (-15.93%) ⬇️
src/services/EvalFactor.jl 69.06% <ø> (-8.29%) ⬇️
src/services/FactorGraph.jl 62.44% <40.00%> (-12.01%) ⬇️
src/services/GraphProductOperations.jl 87.09% <83.33%> (-2.56%) ⬇️
src/services/ApproxConv.jl 56.97% <100.00%> (-40.73%) ⬇️
src/services/SolveTree.jl 93.97% <100.00%> (ø)
src/services/SolverUtilities.jl 52.00% <100.00%> (ø)

... and 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann marked this pull request as ready for review September 18, 2023 09:45
@dehann dehann changed the title fixes, debugging, wip on derel test fixes, debugging, wip on DERelative tests Sep 18, 2023
@dehann dehann merged commit ad00c3b into master Sep 18, 2023
@Affie Affie modified the milestones: v0.34.2, v0.35.0 Oct 17, 2023
@dehann dehann deleted the 23Q3/enh/derel_getsample branch November 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants