fixes, debugging, wip on DERelative tests #1774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue remains with
solveTree
breaking the result. See broken_tests in this PR. The issue is that although initAll! does good job, the follow-on solve tree with.useMsgLikelihoods=false
(over 4 cliques) resets some of the variables to values[0,0]
, and so:sampleFactor
togetSample
instead (finally able with newCalcFactor
design).some improvements relating to: