Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple accumulateFactorMeans bugs #1700

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Mar 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1700 (1e921b9) into master (c855c31) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
+ Coverage   76.57%   76.59%   +0.01%     
==========================================
  Files          74       74              
  Lines        5614     5614              
==========================================
+ Hits         4299     4300       +1     
+ Misses       1315     1314       -1     
Impacted Files Coverage Δ
src/ConsolidateParametricRelatives.jl 100.00% <ø> (ø)
src/services/CalcFactor.jl 78.66% <ø> (ø)
src/services/EvalFactor.jl 81.76% <ø> (ø)
src/services/TetherUtils.jl 56.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann
Copy link
Member Author

dehann commented Mar 28, 2023

Hi @Affie , just a fyi on some of the parametric solve tools, for going through through one or two factors. I found some bugs here recently and just wanted to let you know i was able to use accumulateFactorMeans(lfg.., solveKey=:parametric).

@dehann dehann merged commit 9fc1e3d into master Mar 28, 2023
@Affie Affie modified the milestones: v0.33.1, v0.34.0 Apr 28, 2023
@dehann dehann deleted the 23Q1/fix/accumfactorparam branch November 27, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants