Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests not broken w dfg 20 #1690

Merged
merged 3 commits into from
Mar 8, 2023
Merged

tests not broken w dfg 20 #1690

merged 3 commits into from
Mar 8, 2023

Conversation

dehann
Copy link
Member

@dehann dehann commented Mar 4, 2023

No description provided.

@dehann dehann self-assigned this Mar 4, 2023
@dehann dehann added this to the v0.32.3 milestone Mar 4, 2023
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1690 (96a21f2) into master (e49d1c4) will decrease coverage by 20.90%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1690       +/-   ##
===========================================
- Coverage   76.39%   55.50%   -20.90%     
===========================================
  Files          74       74               
  Lines        5618     5598       -20     
===========================================
- Hits         4292     3107     -1185     
- Misses       1326     2491     +1165     
Impacted Files Coverage Δ
src/services/HeatmapSampler.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Factors/PartialPriorPassThrough.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Factors/MetaPrior.jl 0.00% <0.00%> (-80.00%) ⬇️
src/entities/AliasScalarSampling.jl 0.00% <0.00%> (-71.43%) ⬇️
src/services/DeconvUtils.jl 0.00% <0.00%> (-70.50%) ⬇️
src/ccolamd.jl 0.00% <0.00%> (-66.00%) ⬇️
src/services/DefaultNodeTypes.jl 0.00% <0.00%> (-63.64%) ⬇️
src/services/FactorGradients.jl 37.11% <0.00%> (-59.89%) ⬇️
...Serialization/services/SerializingDistributions.jl 18.57% <0.00%> (-54.29%) ⬇️
src/Factors/GenericFunctions.jl 9.58% <0.00%> (-50.94%) ⬇️
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann modified the milestones: v0.32.3, v0.33.0 Mar 6, 2023
@dehann dehann requested a review from Affie March 6, 2023 19:51
Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't pass with the current CI setup until DFG is tagged.

Project.toml Outdated Show resolved Hide resolved
@Affie Affie merged commit 4ac23b2 into master Mar 8, 2023
@dehann dehann deleted the 23Q1/enh/testsnotbroken branch November 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants