Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr testing, better ccw field order towards multihypo checks #1666

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

dehann
Copy link
Member

@dehann dehann commented Dec 29, 2022

get all the ccw fields into a logical sequence. Get all multihypo related fields together. Get all config parameters together. Get all topologic fields together, etc.

Helps with:

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1666 (d516322) into master (3b5eda5) will increase coverage by 9.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   66.59%   76.36%   +9.76%     
==========================================
  Files          72       73       +1     
  Lines        5577     5589      +12     
==========================================
+ Hits         3714     4268     +554     
+ Misses       1863     1321     -542     
Impacted Files Coverage Δ
src/entities/FactorOperationalMemory.jl 100.00% <ø> (ø)
src/services/NumericalCalculations.jl 91.00% <ø> (ø)
src/services/CalcFactor.jl 82.17% <100.00%> (+8.15%) ⬆️
src/services/EvalFactor.jl 81.77% <100.00%> (+3.70%) ⬆️
.../Serialization/entities/FluxModelsSerialization.jl 100.00% <0.00%> (ø)
src/services/TreeMessageUtils.jl 85.27% <0.00%> (+1.16%) ⬆️
src/services/FGOSUtils.jl 72.35% <0.00%> (+1.17%) ⬆️
src/services/ApproxConv.jl 100.00% <0.00%> (+1.19%) ⬆️
.../CliqueStateMachine/services/CliqueStateMachine.jl 90.42% <0.00%> (+1.32%) ⬆️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann added the bug label Dec 29, 2022
@dehann
Copy link
Member Author

dehann commented Dec 29, 2022

not a bug, difference was for AbstractRelative or AbstractPrior

@dehann dehann merged commit 290b5b3 into master Dec 29, 2022
@dehann dehann deleted the 22Q4/refac/ccwfieldorder branch November 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant