Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CalcFactor.manifold, all factors getManifold #1662

Merged
merged 8 commits into from
Dec 29, 2022
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Dec 28, 2022

@dehann dehann marked this pull request as draft December 28, 2022 08:52
@dehann
Copy link
Member Author

dehann commented Dec 28, 2022

This PR is showing bugs downstream with RoME tests on PartialPose3ZRP. Will first clear that before merging here.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #1662 (1c9dd13) into master (72bcea4) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

❗ Current head 1c9dd13 differs from pull request most recent head 90c25e1. Consider uploading reports for the commit 90c25e1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   76.23%   76.14%   -0.09%     
==========================================
  Files          73       73              
  Lines        5610     5614       +4     
==========================================
- Hits         4277     4275       -2     
- Misses       1333     1339       +6     
Impacted Files Coverage Δ
src/Factors/GenericMarginal.jl 25.00% <0.00%> (-3.58%) ⬇️
src/Factors/Mixture.jl 92.30% <ø> (ø)
src/Factors/PartialPriorPassThrough.jl 100.00% <ø> (ø)
src/ParametricUtils.jl 69.81% <ø> (ø)
src/entities/FactorOperationalMemory.jl 100.00% <ø> (+15.38%) ⬆️
src/services/NumericalCalculations.jl 92.00% <ø> (ø)
src/services/EvalFactor.jl 81.63% <33.33%> (-1.96%) ⬇️
src/Factors/PartialPrior.jl 42.85% <50.00%> (+14.28%) ⬆️
src/Deprecated.jl 13.84% <81.81%> (+13.84%) ⬆️
src/services/CalcFactor.jl 81.95% <100.00%> (-2.02%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann merged commit 2d4c5e3 into master Dec 29, 2022
@dehann dehann deleted the 22Q4/enh/cf_manifold branch November 27, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant