Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toward preamble / userCache #1466

Merged
merged 4 commits into from
Jan 10, 2022
Merged

toward preamble / userCache #1466

merged 4 commits into from
Jan 10, 2022

Conversation

dehann
Copy link
Member

@dehann dehann commented Jan 2, 2022

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #1466 (7645553) into master (2c93a91) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 7645553 differs from pull request most recent head 4beac24. Consider uploading reports for the commit 4beac24 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
+ Coverage   77.16%   77.35%   +0.18%     
==========================================
  Files          67       67              
  Lines        4966     5007      +41     
==========================================
+ Hits         3832     3873      +41     
  Misses       1134     1134              
Impacted Files Coverage Δ
src/entities/FactorOperationalMemory.jl 100.00% <ø> (ø)
src/DispatchPackedConversions.jl 62.16% <100.00%> (+3.33%) ⬆️
src/FactorGraph.jl 69.48% <100.00%> (+1.34%) ⬆️
src/services/CalcFactor.jl 89.92% <100.00%> (ø)
src/TreeMessageAccessors.jl 92.30% <0.00%> (-3.53%) ⬇️
src/SolveTree.jl 97.22% <0.00%> (+0.03%) ⬆️
src/CliqStateMachineUtils.jl 81.25% <0.00%> (+0.09%) ⬆️
src/SerializingDistributions.jl 91.56% <0.00%> (+0.10%) ⬆️
src/ParametricUtils.jl 57.63% <0.00%> (+0.14%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c93a91...4beac24. Read the comment docs.

@dehann dehann marked this pull request as ready for review January 10, 2022 02:21
@dehann dehann merged commit b0bc0a9 into master Jan 10, 2022
@dehann dehann modified the milestones: v0.26.2, v0.27.0 Feb 1, 2022
@dehann dehann deleted the 22Q1/enh/preambleCache branch December 16, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Replace PackedFactor convert functions with specific function. Two chicken and egg problems, unpack DFGFactor
1 participant