serialization of HeatmapGridDensity reduced size #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
- Coverage 77.21% 77.18% -0.03%
==========================================
Files 67 67
Lines 4941 4940 -1
==========================================
- Hits 3815 3813 -2
- Misses 1126 1127 +1
Continue to review full report at Codecov.
|
|
also comment xref #1424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See update to NEWS.md for details. Waiving semver in this case, since the change only affects a 24 hour history and downstream RoME and Caesar versions have not been tagged using new HeatmapGridDensity, even less the associated serialization. Opting for faster standardization in this particular case.