differential factors from deconv tangents to points #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehann
changed the title
dehann
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
- Coverage 76.48% 76.47% -0.01%
==========================================
Files 67 67
Lines 4920 4923 +3
==========================================
+ Hits 3763 3765 +2
- Misses 1157 1158 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a change that came as part of Manifolds.jl upgrade. This PR restricts to only Lie group manifolds, but advances differential factors to use new approxDeconv which now returns tangents (previously was always assumed just to be tangents). Relaxing the Lie group assumption should happen along with #1010
Closes #1386