Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ccw.partialDims #1220

Merged
merged 4 commits into from
Apr 10, 2021
Merged

add ccw.partialDims #1220

merged 4 commits into from
Apr 10, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Apr 10, 2021

towards #1206

see updated test result with proper correlation during "multi-partials":
JuliaRobotics/RoME.jl#434 (comment)

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #1220 (94070a8) into master (ed37b39) will decrease coverage by 0.03%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   74.08%   74.05%   -0.04%     
==========================================
  Files          55       55              
  Lines        4607     4613       +6     
==========================================
+ Hits         3413     3416       +3     
- Misses       1194     1197       +3     
Impacted Files Coverage Δ
src/DispatchPackedConversions.jl 51.51% <0.00%> (ø)
src/IncrementalInference.jl 87.50% <ø> (ø)
src/FGOSUtils.jl 72.56% <60.00%> (-0.40%) ⬇️
src/ApproxConv.jl 88.88% <83.33%> (-0.84%) ⬇️
src/CalcFactor.jl 79.16% <100.00%> (ø)
src/FactorGraph.jl 71.10% <100.00%> (+0.26%) ⬆️
src/FactorGraphTypes.jl 100.00% <100.00%> (ø)
src/GraphProductOperations.jl 94.23% <100.00%> (+0.11%) ⬆️
src/JunctionTree.jl 84.61% <100.00%> (-0.03%) ⬇️
src/SerializingDistributions.jl 68.75% <0.00%> (-1.57%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed37b39...94070a8. Read the comment docs.

@dehann dehann marked this pull request as ready for review April 10, 2021 15:53
@dehann dehann merged commit 1cdc94b into master Apr 10, 2021
@dehann dehann self-assigned this Apr 11, 2021
@dehann dehann linked an issue Apr 11, 2021 that may be closed by this pull request
@dehann dehann deleted the 21Q2/enh/partialdims branch August 13, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New localProduct too eager on partials as 1DOF only
1 participant