Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates towards MKD switch #1202

Merged
merged 6 commits into from
Mar 18, 2021
Merged

updates towards MKD switch #1202

merged 6 commits into from
Mar 18, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Mar 11, 2021

towards #1010 and #1206

@dehann dehann added this to the v0.22.0 milestone Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1202 (d37e989) into master (22898c5) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   73.21%   73.16%   -0.06%     
==========================================
  Files          55       55              
  Lines        4697     4699       +2     
==========================================
- Hits         3439     3438       -1     
- Misses       1258     1261       +3     
Impacted Files Coverage Δ
src/CliqueStateMachine.jl 92.25% <ø> (ø)
src/ExplicitDiscreteMarginalizations.jl 96.00% <ø> (ø)
src/FGOSUtils.jl 74.55% <0.00%> (-0.90%) ⬇️
src/IncrementalInference.jl 87.50% <ø> (ø)
src/Deprecated.jl 14.44% <25.00%> (ø)
src/Factors/Circular.jl 86.95% <86.95%> (ø)
src/ApproxConv.jl 89.72% <100.00%> (ø)
src/SerializingDistributions.jl 68.75% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22898c5...d37e989. Read the comment docs.

@@ -1,5 +1,5 @@

export Sphere1Sphere1, PriorSphere1, PackedSphere1Sphere1, PackedPriorSphere1
export CircularCircular, PriorCircular, PackedCircularCircular, PackedPriorCircular
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dehann dehann marked this pull request as ready for review March 18, 2021 21:17
@dehann dehann self-assigned this Mar 18, 2021
@dehann dehann merged commit 2ec63bc into master Mar 18, 2021
@dehann dehann deleted the 21Q1/maint/mkd branch April 27, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant