solveCliq! in isolation #1169
Merged
solveCliq! in isolation #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
added
question
API
design
bayes junction tree
clique state machine
bug fix
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dehann, I don't know if this is what you had in mind for
solveCliqu!from #1168.I didn't know exactly what we wanted to do with solveCliq!. Problem was: It is still solving as if its part of the larger tree, so it's trying to access messages from the rest of the tree. It's easy to add the channels for the messages but then it would just block on them waiting. So where should these messages come from?
For this PR I went with solving the clique in isolation, it doesn't make sense if its not a leave clique though.