Return Residual in CalcFactor #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
+ Coverage 70.27% 71.71% +1.43%
==========================================
Files 55 55
Lines 4282 4613 +331
==========================================
+ Hits 3009 3308 +299
- Misses 1273 1305 +32
Continue to review full report at Codecov.
|
dehann
requested changes
Feb 5, 2021
dehann
reviewed
Feb 5, 2021
| @@ -43,7 +43,7 @@ function _solveLambdaNumeric( fcttype::Union{F,<:Mixture{N_,F,S,T}}, | |||
| # | |||
|
|
|||
| # | |||
| r = nlsolve(objResX, u0, inplace=true) | |||
| r = nlsolve( (res, x) -> res .= objResX(x), u0, inplace=true) | |||
There was a problem hiding this comment.
Ah, you are doing the opposite of what I was doing. I had residual explicitly available for in-place operations (which we will still keep somewhere in CalcFactor.residual::T for hard in-place factor situations).
I see here now that you are changing to a more implicit usage of residual in the Roots (NLsolve.jl) case. I did not see this before, sorry if I missed it.
Affie
commented
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP towards #467