Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoinit vs setValKDE #124

Closed
mc2922 opened this issue Aug 13, 2018 · 5 comments
Closed

autoinit vs setValKDE #124

mc2922 opened this issue Aug 13, 2018 · 5 comments

Comments

@mc2922
Copy link

mc2922 commented Aug 13, 2018

This initialization procedure with setValKDE appears to take into account tight GPS priors correctly, whereas doautoinit appears to initialize around (0,0) only.

for sm in [Symbol("x$i") for i in 1:5]
  IIF.doautoinit!(fg,sm)
  setValKDE!(getVert(fg,sm),kde!(getSample(getfnctype(getVert(fg, Symbol("$(sm)f1"),nt=:fnc)),N)[1]))
end

See: PropFac/examples/testBackwards.jl

@dehann
Copy link
Member

dehann commented Aug 24, 2018

Thanks, this is useful information -- I will get this fixed!

@dehann dehann added this to the v0.3.8+ milestone Aug 24, 2018
@dehann dehann modified the milestones: v0.3.9, v0.4.0+ Sep 25, 2018
@pvazteixeira
Copy link
Collaborator

function manual_init(fgl::FactorGraph, sym::Symbol, usefct::Symbol)
  # developed when autoinit was not working properly -- should be used with care
  warn("manual_init being used as a workaround for temporary autoinit issues.")
  pts = IIF.approxConv(fgl, usefct, sym)
  X2pre = KDE.kde!(pts)
  IIF.setValKDE!(fgl, sym, X2pre)
  getData(fgl, sym).initialized = true
  nothing
end

@dehann
Copy link
Member

dehann commented Mar 26, 2019

also see, eg. manualinit!(fg, :l0, [:l0f1]), updated in #238

@dehann dehann modified the milestones: shortlist, v0.6.0 May 13, 2019
@dehann
Copy link
Member

dehann commented May 13, 2019

partially related to tree based initialization.

@dehann
Copy link
Member

dehann commented May 29, 2019

mostly resolved through tree initialization introduced during v0.6.x

@dehann dehann closed this as completed May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants