Skip to content

Commit

Permalink
drop warning
Browse files Browse the repository at this point in the history
  • Loading branch information
dehann committed Oct 12, 2023
1 parent 3b44e29 commit 9d6c581
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/entities/CalcFactor.jl
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ _nvars(::CalcFactorResidual{FT, C, D, L, P, MEAS, N}) where {FT, C, D, L, P, MEA
# _typeof_meas(::CalcFactorManopt{FT, C, D, L, MEAS, N}) where {FT, C, D, L, MEAS, N} = MEAS
DFG.getDimension(::CalcFactorResidual{FT, C, D, L, P, MEAS, N}) where {FT, C, D, L, P, MEAS, N} = D

# FIXME HACK workaround for issue #1781
# workaround for issue #1781
import Base: getproperty
function Base.getproperty(cf::CalcFactorResidual, f::Symbol)
if f === :manifold
@warn "CalcFactorResidual.manifold workaround FIXME" maxlog=10
# assumes constant propagation to avoid allocations in residual functions getManifold(factor)
getManifold(cf.factor)

Check warning on line 128 in src/entities/CalcFactor.jl

View check run for this annotation

Codecov / codecov/patch

src/entities/CalcFactor.jl#L128

Added line #L128 was not covered by tests
else
getfield(cf, f)
Expand Down

0 comments on commit 9d6c581

Please sign in to comment.