Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum GraphPlot = "0.4" #699

Closed
wants to merge 1 commit into from
Closed

minimum GraphPlot = "0.4" #699

wants to merge 1 commit into from

Conversation

dehann
Copy link
Member

@dehann dehann commented Nov 30, 2020

Problem with compat, see JuliaRobotics/AprilTags.jl#57

This breaks Pkg compat quite badly, not sure where the issue is coming from.

just cc'ing @Affie on this too

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #699 (c6ea6d5) into master (980938f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   80.62%   80.62%           
=======================================
  Files          33       33           
  Lines        2297     2297           
=======================================
  Hits         1852     1852           
  Misses        445      445           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980938f...c6ea6d5. Read the comment docs.

@Affie
Copy link
Member

Affie commented Nov 30, 2020

Hi, GraphPlot is an optional requirement with Requires.jl. The last time I checked there was no way to specify optional Requires.jl compact. see JuliaPackaging/Requires.jl#82 and JuliaPackaging/Requires.jl#3

Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphPlot is not in deps but a Requires.jl import, also see this comment: JuliaPackaging/Requires.jl#3 (comment)

@Affie
Copy link
Member

Affie commented Nov 30, 2020

I previously thought of waiting for something like this (JuliaLang/Pkg.jl#1285) to be implemented

@dehann
Copy link
Member Author

dehann commented Nov 30, 2020

The last time I checked there was no way to specify optional Requires.jl compat

Got it thanks

@dehann dehann modified the milestones: v0.11.0, v0.0.x Dec 4, 2020
@dehann dehann modified the milestones: v0.0.x, v0.15.0 Jun 29, 2021
@dehann dehann closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants