Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back some deprecated for a bit longer and backward compat for loadDFG #620

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

Affie
Copy link
Member

@Affie Affie commented Aug 15, 2020

should close #618

@Affie Affie added maintenance deprecation VariableType This used to be called softtype (#603) labels Aug 15, 2020
@Affie Affie added this to the v0.10.0 milestone Aug 15, 2020
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #620 into master will decrease coverage by 0.74%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
- Coverage   80.28%   79.54%   -0.75%     
==========================================
  Files          33       33              
  Lines        2196     2219      +23     
==========================================
+ Hits         1763     1765       +2     
- Misses        433      454      +21     
Impacted Files Coverage Δ
src/Deprecated.jl 0.00% <0.00%> (ø)
src/services/Serialization.jl 73.24% <100.00%> (+0.17%) ⬆️
src/DataBlobs/services/BlobStores.jl 76.31% <0.00%> (-3.38%) ⬇️
src/CloudGraphsDFG/services/CGStructure.jl 60.00% <0.00%> (-2.61%) ⬇️
src/CloudGraphsDFG/services/CloudGraphsDFG.jl 69.05% <0.00%> (-1.39%) ⬇️
src/services/AbstractDFG.jl 84.87% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3435826...d5df251. Read the comment docs.

src/Deprecated.jl Outdated Show resolved Hide resolved
src/Deprecated.jl Outdated Show resolved Hide resolved
@Affie Affie changed the title put back deprecated for a bit longer and backward compat for loadDFG Put back some deprecated for a bit longer and backward compat for loadDFG Aug 16, 2020
@Affie Affie merged commit ff56034 into master Aug 16, 2020
@Affie Affie deleted the depr/20Q3/leave_depr_longer branch October 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation maintenance VariableType This used to be called softtype (#603)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility of loadDFG! with new module naming?
2 participants