Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save/load softtype with module #605

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Save/load softtype with module #605

merged 3 commits into from
Aug 14, 2020

Conversation

Affie
Copy link
Member

@Affie Affie commented Aug 13, 2020 •
edited
Loading

close #157

  • FileDFG
  • CGDFG

@Affie Affie added enhancement New feature or request serialization VariableType This used to be called softtype (#603) labels Aug 13, 2020
@Affie Affie added this to the v0.10.0 milestone Aug 13, 2020
@Affie Affie force-pushed the feat/20Q3/modul_softtype branch from 4a4cd57 to e045162 Compare August 13, 2020 14:40
@Affie Affie changed the title Save/load module with softtype Save/load softtype with module Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #605 into master will decrease coverage by 0.34%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   80.30%   79.95%   -0.35%     
==========================================
  Files          33       33              
  Lines        2188     2205      +17     
==========================================
+ Hits         1757     1763       +6     
- Misses        431      442      +11
Impacted Files Coverage Δ
src/CloudGraphsDFG/services/CommonFunctions.jl 83.52% <0.00%> (ø)
src/services/Serialization.jl 73.07% <56.00%> (-4.63%) ⬇️
src/CloudGraphsDFG/services/CloudGraphsDFG.jl 70.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ba70f...56af037. Read the comment docs.

@Affie Affie marked this pull request as ready for review August 14, 2020 09:34
@Affie Affie requested review from GearsAD and dehann August 14, 2020 10:32
@dehann dehann removed their request for review August 14, 2020 10:53
@dehann
Copy link
Member

dehann commented Aug 14, 2020 •
edited
Loading

I bit too busy to review now sorry, we spoke previously and sounds fine.

GearsAD
GearsAD reviewed Aug 14, 2020
View reviewed changes
src/services/Serialization.jl
@@ -40,6 +39,43 @@ function standardizeZDTStrings!(T, interm::Dict)
nothing
end

function string2ZonedDateTime(stringTimestamp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just to keep it in case we want to use it. It's not in use at the moment.

@Affie Affie merged commit a0c0299 into master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GearsAD GearsAD GearsAD approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request serialization VariableType This used to be called softtype (#603)
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Use module in DFGVariable softtype serialize/deserialize
3 participants
@Affie @dehann @GearsAD