Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Standardization through testing #276

Merged
merged 13 commits into from
Feb 5, 2020
Merged

Conversation

Affie
Copy link
Member

@Affie Affie commented Feb 3, 2020

  • Restructuring interface test
  • Improving test coverage with functions, errors, warnings, deprecation, etc
  • Fixing small stuff along the way
  • Towards standard API
  • Towards test reuse and cross driver tests

ref #134
ref #145
ref #182

Based on #134, default will be an exception (preferably not ErrorException TODO). Then a flag can be added later if we still want.

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@b61fd3a). Click here to learn what that means.
The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #276   +/-   ##
==========================================
  Coverage           ?   68.81%           
==========================================
  Files              ?       42           
  Lines              ?     1783           
  Branches           ?        0           
==========================================
  Hits               ?     1227           
  Misses             ?      556           
  Partials           ?        0
Impacted Files Coverage Δ
src/entities/DFGVariable/VariableNodeData.jl 75% <ø> (ø)
src/LightDFG/services/LightDFG.jl 95.13% <ø> (ø)
src/sandbox.jl 0% <0%> (ø)
src/GraphsDFG/services/GraphsDFG.jl 94.11% <100%> (ø)
src/CloudGraphsDFG/services/CloudGraphsDFG.jl 74.32% <100%> (ø)
src/services/AbstractDFG.jl 86.41% <100%> (ø)
src/services/DFGFactor.jl 66.66% <100%> (ø)
src/GraphsDFG/entities/GraphsDFG.jl 100% <100%> (ø)
src/services/DFGVariable.jl 74.38% <33.33%> (ø)
src/Deprecated.jl 86.66% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61fd3a...f8a8b4a. Read the comment docs.

@Affie Affie marked this pull request as ready for review February 5, 2020 12:12
@Affie Affie merged commit dbae574 into develop Feb 5, 2020
@Affie Affie deleted the refactor/20Q1/APIandTest branch February 5, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants