Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression on Unit test for AprilTags preimage calibration #928

Closed
dehann opened this issue Nov 29, 2022 · 1 comment
Closed

Performance regression on Unit test for AprilTags preimage calibration #928

dehann opened this issue Nov 29, 2022 · 1 comment
Labels
AprilTags CI Continuous Integration performance regression testing
Milestone
v0.14.0

Comments

@dehann
Copy link
Member

dehann commented Nov 29, 2022

The unit tests printing out finding preimage i is suddenly much slower than it used to be. This follows local anecdotal observations upon upgrading to Julia 1.8.3.
@dehann dehann added this to the v0.0.x milestone Nov 29, 2022
dehann added a commit that referenced this issue Nov 29, 2022
@dehann
performance regression, #928
982e5d0
@dehann dehann modified the milestones: v0.0.x, v0.14.0 Feb 3, 2023
@dehann
Copy link
Member Author

dehann commented Feb 3, 2023

Looks like this was fixed again somehow. Must have been something upstream. Maybe there was a type-stability issue induced somewhere. Either way, looks to be fixed again.

@dehann dehann closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AprilTags CI Continuous Integration performance regression testing
Projects
Code Quality & Improvements
Status: Done
Milestone
v0.14.0
Development

No branches or pull requests
1 participant
@dehann