Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix manifoldProduct oldpoints to coordinates #94

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

Affie
Copy link
Member

@Affie Affie commented Jul 7, 2021

bugfix from work session

This fixes 2 bugs:

  • Sphere(2) tests
  • SO(n) tests

@codecov-commenter
Copy link

Codecov Report

Merging #94 (1bc8f77) into master (0863e67) will decrease coverage by 9.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   38.91%   29.62%   -9.29%     
==========================================
  Files          16       16              
  Lines         514      513       -1     
==========================================
- Hits          200      152      -48     
- Misses        314      361      +47     
Impacted Files Coverage Δ
src/entities/ManifoldKernelDensity.jl 100.00% <ø> (ø)
src/API.jl 53.33% <100.00%> (-7.54%) ⬇️
src/KernelHilbertEmbeddings.jl 0.00% <0.00%> (-100.00%) ⬇️
src/services/ManifoldKernelDensity.jl 24.59% <0.00%> (-27.87%) ⬇️
src/Legacy.jl 57.37% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0863e67...1bc8f77. Read the comment docs.

@dehann dehann merged commit 3f6da67 into master Jul 8, 2021
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants