Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp MazeUndirected & MazeDirected #156

Merged

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Remove old MazeUndirected and MazeDirected.
  2. Add new MazeUndirectedModule.MazeUndirected and MazeDirectedModule.MazeDirected with improved implementation.
  3. Update tests.
  4. Update README.

Here is how the new environments look:

MazeUndirectedModule.MazeUndirected:

maze_undirected

MazeDirectedModule.MazeDirected:

maze_directed

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #156 (5cd9017) into master (010452d) will decrease coverage by 1.29%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   71.80%   70.51%   -1.30%     
==========================================
  Files          26       27       +1     
  Lines        2472     2479       +7     
==========================================
- Hits         1775     1748      -27     
- Misses        697      731      +34     
Impacted Files Coverage Δ
src/envs/envs.jl 69.69% <ø> (ø)
src/envs/maze_directed.jl 71.42% <71.42%> (ø)
src/envs/maze_undirected.jl 86.00% <86.00%> (ø)
src/rlbase.jl 83.82% <87.50%> (+1.13%) ⬆️
src/envs/snake.jl 80.48% <0.00%> (-14.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010452d...5cd9017. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit 9a2f104 into JuliaReinforcementLearning:master Jul 4, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the revamp_maze branch July 4, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants