Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp GridRoomsUndirected and GridRoomsDirected #154

Merged

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Remove old GridRoomsUndirected and GridRoomsDirected.
  2. Add new GridRoomsUndirectedModule.GridRoomsUndirected and GridRoomsDirectedModule.GridRoomsDirected.
  3. Rename RLBaseGridWorld to RLBaseEnv.
  4. Fix and update README.
  5. Update tests.

Here is how the new environments look:

GridRoomsUndirectedModule.GridRoomsUndirected:

grid_rooms_undirected

GridRoomsDirectedModule.GridRoomsDirected:

grid_rooms_directed

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #154 (f4bee64) into master (c585c20) will decrease coverage by 1.11%.
The diff coverage is 73.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   74.35%   73.24%   -1.12%     
==========================================
  Files          24       25       +1     
  Lines        2379     2396      +17     
==========================================
- Hits         1769     1755      -14     
- Misses        610      641      +31     
Impacted Files Coverage Δ
src/play.jl 0.00% <0.00%> (ø)
src/rlbase.jl 58.33% <57.14%> (-6.38%) ⬇️
src/envs/grid_rooms_directed.jl 71.42% <71.42%> (ø)
src/envs/envs.jl 93.75% <77.77%> (-6.25%) ⬇️
src/envs/grid_rooms_undirected.jl 81.81% <81.81%> (ø)
src/envs/dynamic_obstacles.jl 92.40% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c585c20...f4bee64. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit f5a27bf into JuliaReinforcementLearning:master Jul 3, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the grid_rooms branch July 3, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants