Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle subpackage tags in is_backport #344

Merged

Conversation

IanButterworth
Copy link
Member

Fixes #343

Needs tests.

@IanButterworth
Copy link
Member Author

I think this needs to only regard old tags for the same package though.. so might need to be smarter..

@IanButterworth
Copy link
Member Author

IanButterworth commented Sep 13, 2024

@tpoisot @cadojo can you check that this works on a monorepo package by changing the action to

      - uses: JuliaRegistries/TagBot@ib/is_backport_monorepo

and triggering via the workflow dispatch.

@tpoisot
Copy link

tpoisot commented Sep 13, 2024

will do - later tonight or monday

@tpoisot
Copy link

tpoisot commented Sep 13, 2024

Still not working - the first letter is chomped, and the action crashes because the output isn't a valid version string

@IanButterworth
Copy link
Member Author

Do you have a link to a run?

@IanButterworth
Copy link
Member Author

If you're referring to https://github.com/PoisotLab/SpeciesDistributionToolkit.jl/actions/runs/10856429667/job/30131050466 that appears to be using the latest release not this branch

@tpoisot
Copy link

tpoisot commented Sep 13, 2024

That's the one, but the entry for the subdir I was attempting to release is definitely using the correct branch - I just checked the log

@IanButterworth
Copy link
Member Author

Ah I forgot that you can't just try branches on this action, it has to be built.

I guess we just go for it and release this. The new function has a fail safe anyway.

Can you just do a code review and I'll go ahead. Thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll run the CI once this merges. Thank you so much for the fast fix! My only comment is to remember to remove the _is_backport: from the logging statement.

@IanButterworth IanButterworth merged commit 2370975 into JuliaRegistries:master Sep 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing First Character of Sub-package Prefix
3 participants