-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle subpackage tags in is_backport #344
Fix: handle subpackage tags in is_backport #344
Conversation
I think this needs to only regard old tags for the same package though.. so might need to be smarter.. |
will do - later tonight or monday |
Still not working - the first letter is chomped, and the action crashes because the output isn't a valid version string |
Do you have a link to a run? |
If you're referring to https://github.com/PoisotLab/SpeciesDistributionToolkit.jl/actions/runs/10856429667/job/30131050466 that appears to be using the latest release not this branch |
That's the one, but the entry for the subdir I was attempting to release is definitely using the correct branch - I just checked the log |
Ah I forgot that you can't just try branches on this action, it has to be built. I guess we just go for it and release this. The new function has a fail safe anyway. Can you just do a code review and I'll go ahead. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll run the CI once this merges. Thank you so much for the fast fix! My only comment is to remember to remove the _is_backport:
from the logging statement.
Fixes #343
Needs tests.