-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: TestNoAllocations v0.1.0 #92905
New package: TestNoAllocations v0.1.0 #92905
Conversation
JuliaRegistrator
commented
Oct 6, 2023
- Registering package: TestNoAllocations
- Repository: https://github.com/BloodWorkXGaming/TestNoAllocations.jl
- Created by: @BloodWorkXGaming
- Version: v0.1.0
- Commit: b8ec97f99f22c5ea19ad0bbc8d5314f47fac690c
- Git reference: HEAD
- Description: Simple Helper Macro to test for no allocations in Unit Tests
- Release notes:
UUID: 4f9cea44-66d8-4d7b-9fef-fad96b0e1517 Repo: https://github.com/BloodWorkXGaming/TestNoAllocations.jl.git Tree: b0f29d425e5f83bd13a88ef10c5fbd90c5b2fd4f Registrator tree SHA: 7242ef64be5953fac9bf8b3efa3a7c4d2d44ca09
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
[noblock] EDIT: added this, see comment below. I haven't had time to look at the package, I assume it does as intended just test. I was thinking Dlang has And this is recursive. This is a functionality you may want to have or both, and then the name isn't the best. If I don't see an answer here soon, I think I will unblock my comment. Your package would be registered today, maybe even soon? So sorry about blocking, I just think it's inconvenient to rename, or rather more so after registration... |
[noblock] Having a no_gc annotation would be really awesome, but only if it doesn't affect the performance. Could be possible with metaprogramming, however then it would still affect the first time till it runs once, if I am not mistaking. While these are desirable features, am not too sure what would be the best way to approach it. I am open to idea's tho :) |
[noblock] I need to run now, I can drop by your issue page, likely tomorrow to explain. If you really want to go through with registering this package, then you need to add [noblock] too to your comment here. I only blocked to get your attention. But then you're stuck with the name, so you may want to consider that. People can still add your unregistered package with ]add http://... I do not really want to block you, i.e. get in your way, what you want to do, so I'm sorry for causing the minor delay if you go through with registering. |
[noblock] As I don't need this package for any time critical project I am leaving it on blocked for now, till I decide to go further with it. But that being that, thank you for your help :) |
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
[noblock] I didn't block your package getting merged, you did by not including [noblock], but I can still drop on your page and discuss, I just forgot. There's not really any problem having your package, and then another BlockAllocations.jl or something like that. It's probably not to hard to make such, if your functions are concretely typed. When they are not, your code is generic, it might be really hard, e.g. code for Floats might be ok, but if you call with BigFloat then you should expect allocations, and I don't see a good way around that... |
[noblock] Hi @PallHaraldsson thanks for the headsup. No worries, I know you didn't block it, had very little time to work on it myself, which is why I hadn't unblocked it myself. if you still up for it, I'd be happy to hear your thoughts on this topic on my page :) |
Hi @BloodWorkXGaming I meant to drop by and discuss, but here is a similar new registered package, I think with all I proposed (and overlap with your package, or making it redundant?): |
Hey, thanks for the update! That seems like a very promising package! But I will continue to monitor the other package and I am happy that such a package exists in a more official group! :) Thanks! |