-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict StaticArrays.jl @v1.5- to Julia v1.10- #86950
Conversation
@@ -1,10 +1,19 @@ | |||
["0-0.10"] | |||
julia = ["0.7", "1"] | |||
julia = ["0.7", "1-1.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the title of the PR, you're allowing Julia v1.10, or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I thought we might include the AbstractTriangular
commit, which removed the second type parameter in v1.10, but I guess we are not (it would need to get backported), so I changed it accordingly.
Co-authored-by: Mosè Giordano <[email protected]>
["0.11"] | ||
julia = "1-1.10" | ||
|
||
["0.12-0"] | ||
julia = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this version is compatible with Julia v1.11+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we backported the relevant commit to v0.12.5 or so.
The code erroring in julia-1.11 was removed from |
In this case it seems to be an oversight. |
@vtjnash Is this how it's done? Related to JuliaLang/julia#26307