Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict StaticArrays.jl @v1.5- to Julia v1.10- #86950

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Restrict StaticArrays.jl @v1.5- to Julia v1.10- #86950

merged 4 commits into from
Jul 15, 2023

Conversation

dkarrasch
Copy link
Contributor

@vtjnash Is this how it's done? Related to JuliaLang/julia#26307

@dkarrasch dkarrasch changed the title Restrict StaticArrays.jl @v0.13- to Julia v1.9- Restrict StaticArrays.jl @v1.5- to Julia v1.9- Jul 6, 2023
@@ -1,10 +1,19 @@
["0-0.10"]
julia = ["0.7", "1"]
julia = ["0.7", "1-1.10"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the title of the PR, you're allowing Julia v1.10, or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I thought we might include the AbstractTriangular commit, which removed the second type parameter in v1.10, but I guess we are not (it would need to get backported), so I changed it accordingly.

@dkarrasch dkarrasch changed the title Restrict StaticArrays.jl @v1.5- to Julia v1.9- Restrict StaticArrays.jl @v1.5- to Julia v1.10- Jul 15, 2023
["0.11"]
julia = "1-1.10"

["0.12-0"]
julia = "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this version is compatible with Julia v1.11+?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we backported the relevant commit to v0.12.5 or so.

@giordano giordano merged commit 76a4cc5 into JuliaRegistries:master Jul 15, 2023
@dkarrasch dkarrasch deleted the patch-1 branch July 15, 2023 18:28
@fhagemann
Copy link
Contributor

The code erroring in julia-1.11 was removed from 1.5.16 to 1.5.17, see here.
Is there a reason why the versions 1.5.0-1.5.16 (which still cause errors on julia-1.11) are not excluded as well?

image

@dkarrasch
Copy link
Contributor Author

In this case it seems to be an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants