Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: TurbulenceConvection v0.34.1 #64956

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 8e072fc4-01f8-44fb-b9dc-f9336c367e6b
Repo: https://github.com/CliMA/TurbulenceConvection.jl.git
Tree: b055ef9315d017bbb43aa09f53a8723b7e2f562a

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in CliMA/TurbulenceConvection.jl Jul 25, 2022
1250: params overwrite r=trontrytel a=trontrytel

# PULL REQUEST

## Purpose and Content
This PR adds back an option to overwrite microphysics parameters with a namelist file. This is needed to integrate with CEDMF.

## Questions
- I was trying to print the value of `E_liq_rai` parameter, which is part of `microphys_params` to test if I'm really overwriting them. But I could not figure out how to access it. Any suggestions here?

- This is a little clunky because now we define a default value in CLIMAParameters and in the overwrite file. 

- Some of those parameters would benefit from being specified via command line as well (thinking about the ones that switch on/off processes). Not sure where it fits here


Co-authored-by: Anna Jaruga <[email protected]>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 25, 2022 21:46 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit bf972e0 into master Jul 25, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/turbulenceconvection/8e072fc4/v0.34.1 branch July 25, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants