Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: TurbulenceConvection v0.15.2 #55534

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 8e072fc4-01f8-44fb-b9dc-f9336c367e6b
Repo: https://github.com/CliMA/TurbulenceConvection.jl.git
Tree: 68f54ae5c350b87f16f6b0039c880eae22bc5947

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in CliMA/TurbulenceConvection.jl Feb 26, 2022
842: Skip some computations / io for calibrate_io r=charleskawczynski a=charleskawczynski

I made a flame graph from CalibrateEDMF's julia parallel (pmap) integration test, and it seem that we're somehow paying a pretty steep price for some of the diagnostics. This PR adds `calibrate_io` bool to `Simulation1d` to conditionally skip some of the computations and IO that are not needed for calibration.

<img width="2156" alt="Screen Shot 2022-02-25 at 9 48 15 PM" src="https://user-images.githubusercontent.com/1880641/155831101-1a7a5e9e-f75e-47fc-a07e-ee9cae1da40b.png">


Co-authored-by: Charles Kawczynski <[email protected]>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch February 26, 2022 19:01 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit 8f16ce3 into master Feb 26, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/turbulenceconvection/8e072fc4/v0.15.2 branch February 26, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants