Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version SeisIO: 0.2.0 #531

Merged
merged 1 commit into from
May 6, 2019
Merged

New version SeisIO: 0.2.0 #531

merged 1 commit into from
May 6, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented May 4, 2019

Registering: SeisIO
Repository: https://github.com/jpjones76/SeisIO.jl
Version: v0.2.0
Commit: 6e85d4fe018aa1b48d7fcfd006e591ade71337f9
Proposed by: @jpjones76
Reviewed by: @jpjones76
Reference: jpjones76/SeisIO.jl@6e85d4f#commitcomment-33421478

JuliaRegistrator referenced this pull request in jpjones76/SeisIO.jl May 4, 2019
@fredrikekre
Copy link
Member

Can you add some compatibility constraints on your deps and julia? Also looks like tests failed on Travis.

@jpjones76
Copy link

jpjones76 commented May 5, 2019

Where do I need to add the compatibility constraints? I don't intend to support it for Julia 0.6, so should I just delete REQUIRE instead?

Re. last night's failed Travis test, the circumstances were so rare that I hadn't even written a try/catch loop around the possibility -- literally the first example of that error in SeedLink after hundreds of trials. I reran the tests and succeeded.

@fredrikekre
Copy link
Member

Where do I need to add the compatibility constraints?

You add a [compat] section to your project file, see https://julialang.github.io/Pkg.jl/v1/compatibility/, e.g.

[compat]
julia = "1"
SomePackage = "0.5, 0.6"

etc.

should I just delete REQUIRE instead?

Yea, that can be removed.

@jpjones76
Copy link

OK. Took care of both. Do you need me to delete the release and then rerelease it?

@fredrikekre
Copy link
Member

fredrikekre commented May 5, 2019

Just retrigger the bot and this PR will be updated.

UUID: b372bb87-02dd-52bb-bcf6-c30dd83fd342
Repo: https://github.com/jpjones76/SeisIO.jl.git
Tree: 0a6835508b06fd6e2d8c105da3a66ad6082b86f2

Registrator tree SHA: 32d2287682a72e1e8db6e8efb3bda9f68cd578af
@JuliaRegistrator JuliaRegistrator force-pushed the register/SeisIO/v0.2.0 branch from bb0152b to 877870f Compare May 6, 2019 08:03
JuliaRegistrator referenced this pull request in jpjones76/SeisIO.jl May 6, 2019
@fredrikekre fredrikekre merged commit 7ef040f into master May 6, 2019
@julia-tagbot
Copy link

julia-tagbot bot commented May 6, 2019

I tried to create a release but ran into this error:

POST https://api.github.com/repos/jpjones76/SeisIO.jl/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

To retry, comment on this PR with the phrase TagBot tag.
cc: @christopher-dG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants