-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lower bounds for EllipsisNotation version 1.1.2 #49611
Conversation
Update lower bounds of 1.1.2 to ArrayInterface 3.1 and below
No, it needs a lower bound of ArrayInterface 3.2 otherwise the method you're using is not defined. So v1.1.2 should essentially get a registry update to have the same bounds as v1.1.3. @DilumAluthge created tools to help for this you might want to use. |
Co-authored-by: Christopher Rackauckas <[email protected]>
Did you check this registry works well locally? If so, I'll merge. |
Is the intention to make EllipsisNotation 1.1.2 have the same compat on ArrayInterface as EllipsisNotation 1.1.3? In that case I think: diff --git a/E/EllipsisNotation/Compat.toml b/E/EllipsisNotation/Compat.toml
index dab59d0223..25e80c634f 100644
--- a/E/EllipsisNotation/Compat.toml
+++ b/E/EllipsisNotation/Compat.toml
@@ -7,8 +7,8 @@ julia = "1"
["1.1-1"]
julia = "1.5.0-1"
-["1.1-1.1.2"]
+["1.1-1.1.1"]
ArrayInterface = "3"
-["1.1.3-1"]
+["1.1.2-1"]
ArrayInterface = "3.2.0-3" |
Yes. What happened was 1.1.2 had a bad lower bound that effected hundreds of downstream packages, so 1.1.3 was an immediate hotfix. This is now cleanup to make sure the version with the bad bound no longer exists in some sense. Still a bit time sensitive |
Okay. The diff above does that. Instead of manually trying to figure out things like this, have a look at |
Awesome, thanks a ton. Yeah I was out yesterday but needed a bit of a team effort to handle the breakage emails. This looks great. |
Update lower bounds of 1.1.2 to ArrayInterface 3.1 and below. @ChrisRackauckas, I'm assuming this is the lower bounds you referred to here.