Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple ImageCore compat from 0.7 to 0.8 #392

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Update multiple ImageCore compat from 0.7 to 0.8 #392

merged 1 commit into from
Apr 29, 2019

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Apr 28, 2019

@timholy Hopefully this reduces the pain.. Replaces and expands #389

All add-able to a blank slate package environment, except Caesar.jl due to JuliaLang/Pkg.jl#1169

Ians-MacBook-Pro:.julia ian$ JULIA_DEPOT_PATH=/tmp/pkgs julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.1.0 (2019-01-21)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(v1.1) pkg> add ImageCore
... etc.
(v1.1) pkg> st
    Status `/private/tmp/pkgs/environments/v1.1/Project.toml`
  [a09fc81d] ImageCore v0.8.2
  [d8c32880] ImageInTerminal v0.4.0
  [bc367c6b] ImageMetadata v0.7.0
  [787d08f9] ImageMorphology v0.2.0
  [02fcd773] ImageTransformations v0.7.2
  [e94cdb99] MosaicViews v0.1.0
  [dca85d43] QuartzImageIO v0.6.0

Passing local tests on MacOS 10.14.4 (except for Caesar.jl which is untested due to above)

  • [a09fc81d] ImageCore v0.8.2
  • [d8c32880] ImageInTerminal v0.4.0
  • [bc367c6b] ImageMetadata v0.7.0
  • [787d08f9] ImageMorphology v0.2.0
  • [02fcd773] ImageTransformations v0.7.2
  • [e94cdb99] MosaicViews v0.1.0
  • [dca85d43] QuartzImageIO v0.6.0
  • Caesar -> Not tested due to above

Should we leave Caesar unchanged, given not tested?

@IanButterworth
Copy link
Member Author

Things worth noting..

  1. Where there were multiple ImageCore compat bounds per package, I just edited the last
  2. I didn't look for upper bounds <0.7

@timholy
Copy link
Member

timholy commented Apr 28, 2019

This is probably the right way to do it. In retrospect I was being silly by not just nuking the upper bounds as soon as the bottlenecks started becoming apparent.

Looks like this will need a rebase.

@IanButterworth
Copy link
Member Author

Ok. I've rebased. Apologies, I shouldn't have brought the ImageMorphology changes in here without closing the other PR

@timholy
Copy link
Member

timholy commented Apr 29, 2019

Thanks for doing this!

@fredrikekre
Copy link
Member

Can you rebase on the master branch @ianshmean?

@dehann
Copy link

dehann commented May 7, 2019

Hi @ianshmean , I just noticed this thread now (I'm a maintainer of Caesar.jl) -- is this issue still a problem? I'm a little worried if you are indeed seeing the p0 != p1 assertion error? Issue #1169 was resolved 2 days after your initial post in #455.

The p0 != p1 assertion issue was related to bad compat in IncrementalInference.jl tomls, which is a dependency used by Caesar.jl.

A new version of Caesar (v0.3.1) was tagged yesterday but it's compat only goes up to ImageCore = "0.7". I just tried to install ImageCore with regular package add and it seems to work fine:

(testimagecorecaesar) pkg> status
    Status `~/.julia/environments/testimagecorecaesar/Project.toml`
  [62eebf14] Caesar v0.3.0
  [a09fc81d] ImageCore v0.8.2

ASIDE: Caesar.jl master now has compat at ImageCore = 0.7, 0.8, if interested JuliaRobotics/Caesar.jl#326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants