Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CuArray compatibility with NNlib #327

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Apr 26, 2019

ref JuliaGPU/CuArrays.jl@da7107b
fix JuliaGPU/CuArrays.jl#327

OT: what does the -0 mean? CuArrays 1-1.0.1 just has NNlib = "0.5".

@KristofferC
Copy link
Member

It should be:

OT: what does the -0 mean

Compatible up to 1.0 (exclusive)

NNlib = "0.5".

Compatible 0.5 - 0.6 (exclusive). This is "semver notation" for pre 1.0.

@maleadt
Copy link
Contributor Author

maleadt commented Apr 26, 2019

This is "semver notation" for pre 1.0.

Right; then why did JuliaRegistrator convert the NNlib = "0.5, 0.6" compatibility line in Project.toml to a non semver-compatible 0.5-0? I had expected it to be just 0.5-0.6 is why I was confused by the -0.

https://github.com/JuliaGPU/CuArrays.jl/blob/v1.0.2/Project.toml#L34
https://github.com/JuliaRegistries/General/pull/288/files#diff-19dac3c8014f2b183d8c7bac1804f85eR94

@KristofferC
Copy link
Member

There was some normalization that ran but I thought that was a one time thing. This looks wrong, yes. cc @StefanKarpinski

@StefanKarpinski
Copy link
Contributor

Because when I wanted to follow semver strictly, people didn't like that it would require people to change their version bounds when new 0.x versions were released. So for now normalization is done considering all 0.x versions to be compatible. Unless there's a 0.7 version to be incompatible with, 0.5-0.6 is equivalent to 0.5-0.

@maleadt
Copy link
Contributor Author

maleadt commented Apr 27, 2019

Is this good to go? Users are running into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong NNlib bounds wiith CuArrays 1.0.2
4 participants