Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ChainRules v0.7.37 #26142

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 082447d4-558c-5d27-93f4-14fc19e9eca2
Repo: https://github.com/JuliaDiff/ChainRules.jl.git
Tree: 78c2fa84cf13ce7d821f23947f66212c1f504960

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
JuliaRegistrator referenced this pull request in JuliaDiff/ChainRules.jl Dec 9, 2020
* Revamp Cholesky implementation

* Bump patch

* Tidy up + fix syntax

* Reinstate tests

* Update src/rulesets/LinearAlgebra/factorization.jl

Co-authored-by: Seth Axen <[email protected]>

* Update src/rulesets/LinearAlgebra/factorization.jl

Co-authored-by: Seth Axen <[email protected]>

* Conjugate trsm!

Co-authored-by: Seth Axen <[email protected]>

* Rename to DeltaC and use BlasFloat

* Conjugate in both places

* Change diag scaling for Complex

Co-authored-by: Seth Axen <[email protected]>

* Fix naming

* Use HermOrSym and generalise Diagonal chol to complex

* Revert to Real

* Fix naming

* Test cholesky(::Real)

* Tidy up Diagonal cholesky

* Restrict to BlasReal

* Refactor Diagonal pullback slightly

* Reinstate all tests

* Update src/rulesets/LinearAlgebra/factorization.jl

Co-authored-by: Seth Axen <[email protected]>

* Fix up broken tests

* Address code review queries

Co-authored-by: Seth Axen <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit f6dbd47 into master Dec 9, 2020
@JuliaTagBot JuliaTagBot deleted the registrator/chainrules/082447d4/v0.7.37 branch December 9, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants