Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: open PRs to update compat entries for weak dependencies ([weakdeps]) #452

Closed
prbzrg opened this issue Jul 17, 2023 · 3 comments · Fixed by #458
Closed

Comments

@prbzrg
Copy link

prbzrg commented Jul 17, 2023

the compats for weakdeps isn't getting any update.

@DilumAluthge DilumAluthge changed the title FR: update for weekdeps Feature request: open PRs to update compat entries for weak dependencies ([weakdeps]) Jul 17, 2023
@sethaxen
Copy link
Contributor

Is it possible this is as simple as changing this line to also look at weakdeps?

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 16, 2023

You probably need to wrap that entire if block in a for loop that has two iterations. The first iteration will look for deps/compat, and the second iteration will look for weakdeps/weakcompat.

@DilumAluthge
Copy link
Member

Also, we probably want to have some way of mentioning (in the PR title) that a CompatHelper PR is for a weakdep (as opposed to a regular dep).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants