Generalize or concretize ReachSet container types #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the "dev" build is green. So we would need to release a new version of |
|
This hack does not work anymore because of static arrays. Strange that it hit us so quickly, but it was a hack after all. |
mforets
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690.
This PR solves the problem, but with an ugly hack.
The better way is to remove the type parameters of
ReachSolution. This makes sense because the exact type is not known by an algorithm (because even if we know the set type, there are type parameters that we do not know in advance).I did the first steps for that in #694, but it requires merging or removing the
projectmethods of the CPost operatorsGLGM06andTMJets. This is anyway reasonable now with the new projection based on individualReachSets, but I did not have time for the change.