Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#686 - Decomposition for ASB07 #688

Merged
merged 3 commits into from
Oct 16, 2019
Merged

#686 - Decomposition for ASB07 #688

merged 3 commits into from
Oct 16, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Sep 24, 2019

Closes #686.

For now I called the operator ASB07_decomposed. We can rename it later.

I again have the problem that the set type for ReachSolution must be concrete. We should really get rid of this because it limits us everywhere (the workaround so far is to use LazySet everywhere). As suggested by @mforets, I added a workaround for now.
There is also JuliaReach/LazySets.jl#1726 which could be incorporated later (I left a TODO in the code).

Homogeneous system:
linear_original
linear_decomposed

Heterogeneous system:
affine_original
affine_decomposed

@schillic schillic changed the title WIP #686 - Decomposition for ASB07 #686 - Decomposition for ASB07 Sep 25, 2019
@schillic schillic requested a review from mforets September 25, 2019 07:22
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🎉

@schillic schillic merged commit 464fdcb into master Oct 16, 2019
@schillic schillic deleted the schillic/686 branch October 16, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decomposition for ASB07
2 participants