-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checking property for flowpipes with mixed dimensions #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Can you add a test that covers the new functionality? This could be re-using some of the existing models and just changing algorithm-specific options.
As far as I know we don't have a check for hybrid systems at all. I can consider thermostat model and a bad state x<=18, does it work for you? |
098e6e5
to
cbc556a
Compare
Yes we do; i mean check in the sense of running the new code in some problem(s). I recall that doing this kind of "check" uncovered 2 distinct problems in BFFPS. This is the baseline check of course (test that the code actually works in the examples of the test folder). If you also have |
What @kostakoida means is "property checking for hybrid models," and indeed we do not test this at the moment. I think the property suggested is fine and it should be easy to add that (if not, let me know). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits, please?
15781c1
to
8a6b939
Compare
No description provided.