Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking property for flowpipes with mixed dimensions #660

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

kpotomkin
Copy link
Collaborator

No description provided.

@kpotomkin kpotomkin requested a review from schillic August 8, 2019 05:26
src/Properties/Conjunction.jl Outdated Show resolved Hide resolved
src/Properties/Disjunction.jl Outdated Show resolved Hide resolved
src/solve.jl Outdated Show resolved Hide resolved
src/solve.jl Outdated Show resolved Hide resolved
src/Properties/BadStatesProperty.jl Outdated Show resolved Hide resolved
src/Properties/BadStatesProperty.jl Outdated Show resolved Hide resolved
src/Properties/SafeStatesProperty.jl Outdated Show resolved Hide resolved
src/Properties/SafeStatesProperty.jl Outdated Show resolved Hide resolved
src/solve.jl Outdated Show resolved Hide resolved
src/solve.jl Outdated Show resolved Hide resolved
@schillic schillic requested a review from mforets August 9, 2019 10:03
src/Properties/BadStatesProperty.jl Outdated Show resolved Hide resolved
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you add a test that covers the new functionality? This could be re-using some of the existing models and just changing algorithm-specific options.

@kpotomkin
Copy link
Collaborator Author

Thanks for the contribution. Can you add a test that covers the new functionality? This could be re-using some of the existing models and just changing algorithm-specific options.

As far as I know we don't have a check for hybrid systems at all. I can consider thermostat model and a bad state x<=18, does it work for you?

@mforets
Copy link
Member

mforets commented Aug 14, 2019

As far as I know we don't have a check for hybrid systems at all.

Yes we do; i mean check in the sense of running the new code in some problem(s). I recall that doing this kind of "check" uncovered 2 distinct problems in BFFPS. This is the baseline check of course (test that the code actually works in the examples of the test folder). If you also have @test for some of the new funcionality that is also welcome!

@schillic
Copy link
Member

schillic commented Aug 14, 2019

Yes we do

What @kostakoida means is "property checking for hybrid models," and indeed we do not test this at the moment. I think the property suggested is fine and it should be easy to add that (if not, let me know).

@schillic schillic requested a review from mforets August 15, 2019 18:33
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits, please?

@schillic schillic merged commit 2959014 into master Aug 16, 2019
@schillic schillic deleted the property_mixed branch August 16, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants