-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#516 - Discretize using matrix interval remainder #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/516
branch
4 times, most recently
from
August 8, 2019 13:21
5477739
to
6221632
Compare
schillic
changed the title
WIP #516 - Discretize using matrix interval remainder
#516 - Discretize using matrix interval remainder
Aug 8, 2019
schillic
force-pushed
the
schillic/516
branch
4 times, most recently
from
August 14, 2019 20:44
15dbbab
to
44aa1cc
Compare
mforets
reviewed
Aug 30, 2019
mforets
requested changes
Aug 30, 2019
mforets
approved these changes
Sep 8, 2019
Can you rebase please? I cannot read these changes. |
mforets
force-pushed
the
schillic/516
branch
from
September 8, 2019 14:25
0323dce
to
db1eacb
Compare
schillic
commented
Sep 8, 2019
Thanks! 👍 (I cannot approve my own PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516.