Update TMJets returning the TMs #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
approved these changes
May 15, 2019
| t[0] = t0 | ||
| tI[0] = t0 | ||
| tv[nsteps] = t0 | ||
| for i in eachindex(x) |
There was a problem hiding this comment.
Maybe do for i, xi in enumerate(x).
| @@ -116,7 +124,7 @@ function validated_integ(f!, qq0::AbstractVector{T}, δq0::IntervalBox{N,T}, | |||
|
|
|||
| end | |||
|
|
|||
| return view(tv,1:nsteps), view(xv,1:nsteps) | |||
| return view(tv,1:nsteps), view(xv,1:nsteps), view(xTM1v, :, 1:nsteps) | |||
There was a problem hiding this comment.
Should you not accept this new output here?
Reachability.jl/src/ReachSets/ContinuousPost/TMJets/post.jl
Lines 50 to 51 in 1bcaf01
There was a problem hiding this comment.
Yes, it should read it (i opened #635 as follow up) and so far it is ignored.
I didn't do it here because there was no obvious workaround: ReachSolution is parametric in LazySet and TaylorModel1 is not a lazy set so i cannot add it to the solution..
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from small tweaks this branch updates wrt TaylorModels#master and the idea of returning the TMs in the solution (before box o.a.). Note, however, that in a follow-up PR we should fully "branch" it to the cont post perhaps adding a new option to choose the type of the solution. Note also that
ReachSolutiontakes arguments of typeLazySetbutTaylorModelis not of that type (we could add this in the future..).