-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port validated integ from TaylorModels #614
Port validated integ from TaylorModels #614
Conversation
Reachability.solve_continuous: Error During Test at /home/travis/build/JuliaReach/Reachability.jl/test/Reachability/alltests.jl:2
Got exception outside of a @test
LoadError: UndefVarError: get_numvars not defined -> the appropriate |
Please add ┌ Warning: Package Reachability does not have TaylorIntegration in its dependencies:
│ - If you have Reachability checked out for development and have
│ added TaylorIntegration as a dependency but haven't updated your primary
│ environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with Reachability
└ Loading TaylorIntegration into Reachability from project dependency, future warnings for Reachability are suppressed. |
|
||
# println(nsteps, "\t", t0, "\t", remainder.(xTMN[:]), "\t", diam(Δ)) | ||
if nsteps > maxsteps | ||
@info(""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to do info("...")
instead to use the logger.
# Output | ||
tv = Array{T}(undef, maxsteps+1) | ||
xv = Array{IntervalBox{N,T}}(undef, maxsteps+1) | ||
# xTMNv = Array{TaylorModelN{N,T,T}}(undef, dof, maxsteps+1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the commented code in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'd like to make that and in general use our guidelines https://github.com/JuliaReach/JuliaReachDevDocs/
Thanks for the contribution! This code is a replacement of The test uses the tests for TMJets so it looks good. Also note that the build error reported in current master is not showing up (i cannot reproduce it either in my machine). Note, however, that a new warning is shown, about In a subsequent PR we'll add early termination with invariant intersection. |
Closes #611.