Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port validated integ from TaylorModels #614

Merged
merged 18 commits into from
Apr 18, 2019
Merged

Port validated integ from TaylorModels #614

merged 18 commits into from
Apr 18, 2019

Conversation

aa25desh
Copy link
Contributor

@aa25desh aa25desh commented Apr 13, 2019

Closes #611.

@mforets
Copy link
Member

mforets commented Apr 14, 2019

Reachability.solve_continuous: Error During Test at /home/travis/build/JuliaReach/Reachability.jl/test/Reachability/alltests.jl:2
  Got exception outside of a @test
  LoadError: UndefVarError: get_numvars not defined

-> the appropriate using is missing, in this case using TaylorSeries: get_numvars.

@mforets
Copy link
Member

mforets commented Apr 14, 2019

Please add TaylorIntegration 0.4.1 in the REQUIRE file, in order to fix the warning:

┌ Warning: Package Reachability does not have TaylorIntegration in its dependencies:- If you have Reachability checked out for development and have
│   added TaylorIntegration as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with Reachability
└ Loading TaylorIntegration into Reachability from project dependency, future warnings for Reachability are suppressed.


# println(nsteps, "\t", t0, "\t", remainder.(xTMN[:]), "\t", diam(Δ))
if nsteps > maxsteps
@info("""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to do info("...") instead to use the logger.

# Output
tv = Array{T}(undef, maxsteps+1)
xv = Array{IntervalBox{N,T}}(undef, maxsteps+1)
# xTMNv = Array{TaylorModelN{N,T,T}}(undef, dof, maxsteps+1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the commented code in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'd like to make that and in general use our guidelines https://github.com/JuliaReach/JuliaReachDevDocs/

@mforets
Copy link
Member

mforets commented Apr 18, 2019

Thanks for the contribution!

This code is a replacement of TaylorModels.validated_integ so we need to add the copyright string, i think it's ok to add it in the same reach.jl file.

The test uses the tests for TMJets so it looks good. Also note that the build error reported in current master is not showing up (i cannot reproduce it either in my machine). Note, however, that a new warning is shown, about update! function. We can investigate it in a new issue.

In a subsequent PR we'll add early termination with invariant intersection.

@mforets mforets merged commit eec2215 into JuliaReach:master Apr 18, 2019
@mforets mforets changed the title [WIP]-Aadesha/port_validated_integ Port validated integ from TaylorModels Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port validated_integ into the TMJets continuous post
3 participants