Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TMJets algorithm #537

Merged
merged 15 commits into from
Mar 21, 2019
Merged

Add TMJets algorithm #537

merged 15 commits into from
Mar 21, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 12, 2019 •
edited
Loading

No description provided.

@schillic schillic mentioned this pull request Mar 13, 2019
Closed
32 tasks
@mforets mforets changed the title WIP - Add TMJets algorithm Add TMJets algorithm Mar 20, 2019
schillic
schillic reviewed Mar 20, 2019
View reviewed changes
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/init.jl Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Outdated Show resolved Hide resolved
@mforets mforets requested a review from schillic March 21, 2019 01:40
schillic
schillic reviewed Mar 21, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated_integ is not found.

REQUIRE Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/TMJets/post.jl Show resolved Hide resolved
src/Utils/systems.jl Outdated Show resolved Hide resolved
test/Reachability/solve_continuous.jl Show resolved Hide resolved
@mforets
Copy link
Member Author

mforets commented Mar 21, 2019

validated_integ is not found.

That's because validated_integ lives in the branch TaylorModels#validatedODEs. We cannot force REQUIRE to use it, but we can pass the branch to be used by travis as a PackageSpec in .travis.yml so it shouldn't be an issue.

( CC: @lbenet )

@schillic
Copy link
Member

but we can pass the branch to be used by travis as a PackageSpec

Then we should do that. Otherwise we will not find "real" errors in our builds anymore.

@mforets mforets mentioned this pull request Mar 21, 2019
Open
@mforets
Copy link
Member Author

mforets commented Mar 21, 2019 •
edited
Loading

LoadError: UndefVarError: normalize_taylor not defined

That's because TaylorSeries hasn't been tagged yet with the code for normalization (reported upstream here). In the meantime, let's just make CI to use the development version.

@schillic schillic mentioned this pull request Mar 21, 2019
Open
@schillic
Copy link
Member

Can we remove check.jl and reach.jl?

@mforets
Copy link
Member Author

mforets commented Mar 21, 2019

Thanks for your help!

I've added #569 as a follow up, so that we can exploit the option :project_reachset.

@mforets mforets merged commit 7117fed into master Mar 21, 2019
@mforets mforets deleted the mforets/TMJets branch March 21, 2019 14:47
@mforets mforets mentioned this pull request Apr 1, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic