Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call modifying init! in solve! #532

Merged
merged 2 commits into from
Mar 10, 2019
Merged

Call modifying init! in solve! #532

merged 2 commits into from
Mar 10, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 10, 2019

  • solve copies the options,

Reachability.jl/src/solve.jl

Line 53 in 1b41551

solve!(system, copy(options), op=op)

  • init copies the options again,

Reachability.jl/src/ReachSets/ContinuousPost/BFFPSV18/BFFPSV18.jl

Line 184 in 1b41551

init(𝒫::BFFPSV18, 𝑆::AbstractSystem, 𝑂::Options) = init!(𝒫, 𝑆, copy(𝑂))

@mforets mforets requested a review from schillic March 10, 2019 10:26
schillic
schillic reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoadError: UndefVarError: init! not defined

There is also a second occurrence here:

Reachability.jl/src/solve.jl

Line 118 in 1b41551

options = init(opD, HS, options_input)

@mforets mforets merged commit 36fa9f4 into master Mar 10, 2019
@mforets mforets deleted the mforets-patch-1 branch March 10, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic